chore: remove :error_handlers from required fields#120
Merged
Annopaolo merged 1 commit intoastarte-platform:release-1.2from Apr 23, 2025
Merged
chore: remove :error_handlers from required fields#120Annopaolo merged 1 commit intoastarte-platform:release-1.2from
:error_handlers from required fields#120Annopaolo merged 1 commit intoastarte-platform:release-1.2from
Conversation
noaccOS
changed the title
:error_handlers from allowed fields:error_handlers from required fields
this fixes the following warning: attempting to determine the presence of embed_many field :error_handlers with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this. as we already have `required: true` in the `cast_embed`, this should be a non-issue Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
force-pushed
the
chore/remove-warning
branch
from
5113351 to
081827e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #120 +/- ##
============================================
Coverage 76.53% 76.53%
============================================
Files 50 50
Lines 861 861
============================================
Hits 659 659
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Annopaolo
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the following warning:
attempting to determine the presence of embed_many field :error_handlers with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.as we already have
required: truein thecast_embed, this should be a non-issuethis is important as it fixes a runtime warning, which pollutes eg tests from astarte-platform/astarte_generators#21